Refactor download function for robustness and retries #15933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the download function to use requests for robust streaming with retries and improved error handling.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15933
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 37 PendingAs of commit de5ca1c with merge base b4d72f1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
meta-cla
bot
added
the
CLA Signed
Added requests library and HTTPAdapter for improved HTTP handling.
cccclai
requested review from
chenweng-quic,
haowhsu-quic,
larryliu0820,
shewu-quic and
winskuo-quic
larryliu0820
approved these changes
Nov 21, 2025
shewu-quic
approved these changes
Nov 21, 2025
cccclai
added a commit
that referenced
this pull request
Nov 21, 2025
It's not compatible with #15933 which cause 2^70+ byte counters like ``` Downloaded: 839890544179019776 / 1354151797 bytes (62023367397.93%) Downloaded: 841813590016000000 / 1354151797 bytes (62165378496.04%) ```
cccclai
added a commit
that referenced
this pull request
Nov 21, 2025
It's not compatible with #15933 which cause 2^70+ byte counters like ``` Downloaded: 839890544179019776 / 1354151797 bytes (62023367397.93%) Downloaded: 841813590016000000 / 1354151797 bytes (62165378496.04%) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like download logic is unstable. Updated the download function to use requests for robust streaming with retries and improved error handling.